Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move errors and warnings to output to stderr #7382

Merged
merged 5 commits into from
Apr 2, 2020
Merged

Move errors and warnings to output to stderr #7382

merged 5 commits into from
Apr 2, 2020

Conversation

tstromberg
Copy link
Contributor

Fixes issue where we inadvertently pollute JSON output with "slow docker" warning: #7381

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 2, 2020
@tstromberg tstromberg added this to the v1.9.1 (regressions) milestone Apr 2, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@codecov-io
Copy link

Codecov Report

Merging #7382 into master will increase coverage by 0.00%.
The diff coverage is 4.34%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7382   +/-   ##
=======================================
  Coverage   37.18%   37.19%           
=======================================
  Files         145      145           
  Lines        8836     8850   +14     
=======================================
+ Hits         3286     3292    +6     
- Misses       5154     5161    +7     
- Partials      396      397    +1
Impacted Files Coverage Δ
cmd/minikube/cmd/config/profile.go 0.00% <0.00%> (ø)
cmd/minikube/cmd/config/profile_list.go 3.79% <0.00%> (ø)
cmd/minikube/cmd/delete.go 25.10% <0.00%> (ø)
cmd/minikube/cmd/logs.go 18.51% <0.00%> (ø)
cmd/minikube/cmd/mount.go 8.84% <0.00%> (ø)
cmd/minikube/cmd/node_add.go 25.00% <0.00%> (ø)
cmd/minikube/cmd/service.go 10.44% <0.00%> (ø)
cmd/minikube/cmd/start.go 34.34% <0.00%> (-0.27%) ⬇️
cmd/minikube/cmd/stop.go 0.00% <0.00%> (ø)
pkg/minikube/logs/logs.go 2.35% <0.00%> (ø)
... and 6 more

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2020
@minikube-pr-bot
Copy link

All Times Minikube (PR 7382): [ 62.940264 62.596238 64.452249]
All Times minikube: [ 66.631944 61.423714 62.523258]

Average minikube: 63.526305
Average Minikube (PR 7382): 63.329584

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7382) |
+----------------------+-----------+--------------------+
| minikube v           |  0.212487 |           0.214855 |
| Creating kvm2        | 40.225555 |          40.537585 |
| Preparing Kubernetes | 20.923259 |          20.802426 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 2, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 65.015572 63.226705 65.156055]
All Times Minikube (PR 7382): [ 67.311615 63.416269 63.117197]

Average minikube: 64.466111
Average Minikube (PR 7382): 64.615027

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7382) |
+----------------------+-----------+--------------------+
| minikube v           |  0.207278 |           0.208909 |
| Creating kvm2        | 41.368903 |          40.594703 |
| Preparing Kubernetes | 21.348727 |          22.358814 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@medyagh
Copy link
Member

medyagh commented Apr 2, 2020 •
edited
Loading

following failures for for docker driver need confirmation PR reply that is not related to this PR.

  • TestStartStop/group/old-docker - 550.49s
  • TestStartStop/group/newest-cni - 111.26s
  • TestStartStop/group/containerd - 191.43s
  • TestStartStop/group/crio - 734.25s
  • TestStartStop/group/embed-certs - 157.68s

@tstromberg
Copy link
Contributor Author

Errors appear unrelated.

@tstromberg tstromberg merged commit 37a9810 into kubernetes:master Apr 2, 2020
@fmotrifork fmotrifork mentioned this pull request Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@medyagh medyagh medyagh approved these changes

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9.1 (regressions)
Development

Successfully merging this pull request may close these issues.
6 participants
@tstromberg @k8s-ci-robot @minikube-pr-bot @codecov-io @medyagh @sharifelgamal